Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Substrate to stable2409 #3078

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Upgrade Substrate to stable2409 #3078

wants to merge 7 commits into from

Conversation

nazar-pc
Copy link
Member

This upgrades Substrate to stable2409 upstream release.

A lot of changes are caused by my refactoring of syncing implementation. I didn't take advantage of it yet to reduce the diff.

I have rebased most of the patches we had that are not yet upstreamed, notable exception is Ved's early runtime patch for state version and some of Shamil's patches for Snap sync that are no longer needed (and I have simplified the remaining since they re-exported more than needed with latest upstream refactoring).

On top of stable release I have also backported following PRs that were already merged into master or remain open, but have a good chance of getting in soon-ish:

All of this is in https://github.com/autonomys/polkadot-sdk/tree/subspace-v8, top commit of which is used in this PR.

Frontier has unmerged polkadot-evm/frontier#1504, which I cloned into https://github.com/autonomys/frontier/tree/subspace-v9 and used here.

I recommend ignoring .toml files during review due to trivial changes (mostly just hash updates and minor dependency changes where necessary).

Code contributor checklist:

@nazar-pc
Copy link
Member Author

Removed custom build_network in domains, https://github.com/autonomys/subspace/pull/2999/files#diff-fdc91ceff50eb11bf372dc47250c4ca95059123cc1d381ec5c867e9fa447244c seems to have effectively restored original version of it

@nazar-pc nazar-pc marked this pull request as ready for review September 30, 2024 18:26
@teor2345
Copy link
Contributor

This seems odd and likely not related to this PR?

You have not agreed to the Xcode license. Please resolve this by running:
sudo xcodebuild -license accept

Both macOS jobs are impacted:
https://github.com/autonomys/subspace/actions/runs/11111943805/job/30872989507?pr=3078#step:6:15
https://github.com/autonomys/subspace/actions/runs/11111943805/job/30872990561?pr=3078#step:6:15

@nazar-pc
Copy link
Member Author

@DaMandal0rian I think this is something for you to fix

Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I don’t have the background to review some of it in detail.

I had one question about task handling, but it’s not a blocker.

crates/sc-consensus-subspace/src/verifier.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants